Add stricter types for onboot/hotplug/bonding parameters #257
Conversation
runejuhl
force-pushed
the
add-stricter-types
branch
from
538fa91
to
49b0f9e
Compare
runejuhl
force-pushed
the
add-stricter-types
branch
from
49b0f9e
to
3b5a2b9
Compare
juniorsysadmin
added
enhancement
|
What's the @voxpupuli convention when making changes with backward-incompatible changes? Any chance of getting this merged in the near future? |
|
@runejuhl It is hard to merge this because it has backward compatible changes by adding data types to the class parameters. This is a very good thing, thank you! Since the PR only changes some of the parameters, it cannot easily be merged because someone else then needs to change the remaining ones. If you could add types to the other parameters, we could definitely get this merged. As it is now, it will probably languish unless someone else wants to checkout your work and then do the rest on top of it. |
|
Hi @ghoneycutt Thank you for the comment. I'll try to find some time to put a bit more work into this PR in the not too distant future ...which will probably end up becoming the "not really near future" 😉 |
|
Dear @runejuhl, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
1 similar comment
|
Dear @runejuhl, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Adds stricter types for
onboot,hotplugand certain bonding parameters.Also fixes issue in
opts-redhat.erbwhen passed a non-string/non-enumerable value. See https://github.com/voxpupuli/puppet-network/compare/master...runejuhl:add-stricter-types?expand=1#diff-6114de1a6f90ec85830d2eab0f0815f7R3 .